linux-kernel - Re: [patch] fs/sysv: dereferencing ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100422102914.GB996@infradead.org>
Date:	Thu, 22 Apr 2010 06:29:14 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Dan Carpenter <error27@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] fs/sysv: dereferencing ERR_PTR()

On Wed, Apr 21, 2010 at 12:30:32PM +0200, Dan Carpenter wrote:
> I moved the dir_put_page() inside the if condition so we don't dereference
> "page", if it's an ERR_PTR().
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch@....de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/