linux-kernel - Re: Status of SquashFS LZMA support in mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BCFA855.8070407@lougher.demon.co.uk>
Date:	Thu, 22 Apr 2010 02:37:25 +0100
From:	Phillip Lougher <phillip@...gher.demon.co.uk>
To:	Tim Bird <tim.bird@...sony.com>
CC:	squashfs-devel@...ts.sourceforge.net,
	linux-embedded <linux-embedded@...r.kernel.org>,
	linux kernel <linux-kernel@...r.kernel.org>,
	Matt Mackall <mpm@...enic.com>
Subject: Re: Status of SquashFS LZMA support in mainline

Tim Bird wrote:
> Does anyone (Phillip?) know the status of SquashFS support
> for LZMA compression in mainline?  I seem to recall that
> Phillip got the patches for this into linux-next sometime
> in January, but I'm not sure if the latest kernel
> (2.6.34-rcxx) includes this or not.
> 

Short answer, no it doesn't include this, Linus rejected my
changes to the LZMA code that made it available for
use by non init code (the LZMA code is currently only used by
initramfs/initrd and the kernel decompression code).

See the thread with the response from Linus here
http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-03/msg01462.html

So even though AFAIK there was no issues with the Squashfs LZMA
wrapper, I had to drop it because it's useless without my changes
to the LZMA code.

I salvaged as much as possible, and submitted a second pull request
with only the new Squashfs decompression framework (so it can use different
decompressors cleanly).  This was accepted.

> I also see in Linus' git tree the following commits in
> March:
> 
> 2010-03-05	Linus Torvalds	Merge git://git.kernel.org/pub/scm/linux/kernel/git...
> ...git://git./linux/kernel/git/pkl/squashfs-linus
> ...org/pub/scm/linux/kernel/git/pkl/squashfs-linus:
> Squashfs: get rid of obsolete definition...
> Squashfs: get rid of obsolete variable...
> Squashfs: add decompressor entries for...
> Squashfs: add a decompressor framework
> Squashfs: factor out remaining zlib dependencies...
> Squashfs: move zlib decompression wrapper...

The partial pull is why the commit history is slightly confusing, part of the
work is there, but all LZMA work is mysteriously missing.

What now?  It's clear the Squashfs LZMA work isn't going to be accepted until
I clean up the STATIC and __init mess that Linus objected to.  This is one
of my next tasks when I get enough free time to work through the issues.  It
may be quite a lot of work because to fix this requires touching quite a
few different architecture files.  It's not something that's going to be fixed
in a couple of evenings :-(

Phillip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/