linux-kernel - Re: [patch] usb: testing the wrong variable in fs_create_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100422162420.GC30730@kroah.com>
Date:	Thu, 22 Apr 2010 09:24:20 -0700
From:	Greg KH <greg@...ah.com>
To:	Dan Carpenter <error27@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alessio Igor Bogani <abogani@...ware.it>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] usb: testing the wrong variable in fs_create_by_name()

On Thu, Apr 22, 2010 at 12:00:52PM +0200, Dan Carpenter wrote:
> There is a typo here.  We should be testing "*dentry" which was just
> assigned instead of "dentry".  This could result in dereferencing an
> ERR_PTR inside either usbfs_mkdir() or usbfs_create().
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Nice catch, thanks.  I'll go queue this up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/