linux-kernel - Re: [Bug #15805] reiserfs locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100422025224.GA12888@nowhere>
Date:	Thu, 22 Apr 2010 04:52:27 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Maciej Rutecki <maciej.rutecki@...il.com>,
	Alexander Beregalov <a.beregalov@...il.com>,
	Jeff Mahoney <jeffm@...freymahoney.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Bug #15805] reiserfs locking

On Tue, Apr 20, 2010 at 05:19:25AM +0200, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a summary report
> of recent regressions.
> 
> The following bug entry is on the current list of known regressions
> from 2.6.33.  Please verify if it still should be listed and let the tracking team
> know (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=15805
> Subject		: reiserfs locking
> Submitter	: Alexander Beregalov <a.beregalov@...il.com>
> Date		: 2010-04-15 21:02 (5 days old)
> Message-ID	: <t2ka4423d671004151402n7b2dc425mdc9c6bb9640d63fb@...l.gmail.com>
> References	: http://marc.info/?l=linux-kernel&m=127136535323933&w=2


That doesn't look like related to the bkl removal.

In fact what I wonder is how we missed that before.

vfs_readdir() take the directory inode mutex
    |
    ------- copy_to_user() takes the mm->mmap_sem

sys_unmap() takes mm->mmap_sem
    |
    ------- reiserfs_file_release() takes inode mutex


The lock inversion can not happen as sys_getdents() can't be called
after the directory is closed.

I'm not sure what to do. Adding more people in Cc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/