linux-kernel - Re: [PATCH] Staging: Comedi: Drivers: Fix coding style issues in dt2801.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1271910971.1730.637.camel@Joe-Laptop.home>
Date:	Wed, 21 Apr 2010 21:36:11 -0700
From:	Joe Perches <joe@...ches.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Gustavo Silva <silvagustavosilva@...il.com>, gregkh@...e.de,
	abbotti@....co.uk, devel@...verdev.osuosl.org,
	fmhess@...rs.sourceforge.net, linux-kernel@...r.kernel.org,
	silvagustavo@...rs.sourceforge.net
Subject: Re: [PATCH] Staging: Comedi: Drivers: Fix coding style issues in
 dt2801.c

On Thu, 2010-04-22 at 06:13 +0200, Wolfram Sang wrote:
> What about dev_* in case there are more than one of those devices?

or netdev_<level>

> Also, KERN_INFO doesn't look right, KERN_WARN?

KERN_WARNING.  Maybe kernel.h should add:
#define pr_warn pr_warning 

so there would be symmetry between levels of
pr_<level>, dev_<level>, netdev_<level>, and netif_<level>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/