linux-kernel - Re: [PATCH 2.6.34-rc1] proc: fix badness in fs/proc/generic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Apr 2010 09:09:19 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	GuanJun He <heguanbo@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.34-rc1] proc: fix badness in fs/proc/generic.c

On Thu, Apr 22, 2010 at 7:10 AM, GuanJun He <heguanbo@...il.com> wrote:
> fix badness in fs/proc/generic.c,  Bug 15589 -  2.6.34-rc1: Badness at
> fs/proc/generic.c:316
> this is just to get least waste.

This is already fixed by powerpc folks, I believe.
Without memory leak.

> --- linux-2.6.34-rc1.orig/fs/proc/generic.c
> +++ linux-2.6.34-rc1/fs/proc/generic.c
> @@ -313,7 +313,15 @@ static int __xlate_proc_name(const char
>                                break;
>                }
>                if (!de) {
> -                       WARN(1, "name '%s'\n", name);
> +                       char *dup = kstrdup(name, GFP_KERNEL);
> +                       if (dup) {
> +                               cp = dup;
> +                               while(*dup) {
> +                                       if (*dup == '/')
> +                                               *dup++ = '_';
> +                               }
> +                               WARN(1, "name '%s'\n", cp);
> +                       }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/