linux-kernel - Re: [PATCH] Staging: rtl8187se: fix coding style errors of r8180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BD0C531.9050104@lwfinger.net>
Date:	Thu, 22 Apr 2010 16:52:49 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Roel Van Nyen <roel.vannyen@...il.com>
CC:	Greg Kroah-Hartman <gregkh@...e.de>,
	"Bartlomiej Zolnierkiewicz devel@...verdev.osuosl.org" 
	<bzolnier@...il.com>,
	Bernhard Schiffner <bernhard@...iffner-limbach.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: fix coding style errors of r8180_rtl8225z2.c

On 04/22/2010 04:37 PM, Roel Van Nyen wrote:
> Fix coding style errors
> 
> Signed-off-by: Roel Van Nyen <roel.vannyen@...il.com>
> 
> ---
> 
>  drivers/staging/rtl8187se/r8180_rtl8225z2.c |   58 ++++++++++++++-------------
> 
>  1 files changed, 30 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/r8180_rtl8225z2.c b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
> 
> index 6edf5a4..9c38b3a 100644
> 
> --- a/drivers/staging/rtl8187se/r8180_rtl8225z2.c
> 
> +++ b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
> 
> @@ -225,7 +225,7 @@ static void rtl8225_SetTXPowerLevel(struct net_device *dev, short ch)
> 
>  }
> 
>  
> 
>  static const u8 rtl8225z2_threshold[] = {
>     <========================= HERE
> -        0x8d, 0x8d, 0x8d, 0x8d, 0x9d, 0xad, 0xbd,
> 
> +    0x8d, 0x8d, 0x8d, 0x8d, 0x9d, 0xad, 0xbd,
> 
>  };

NACK: This patch is badly broken. All of the blank lines like the one I
marked above fail.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/