linux-kernel - Re: [BUGFIX][PATCH] memcg rcu lock fix v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100423150530.469566ab.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 23 Apr 2010 15:05:30 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: Re: [BUGFIX][PATCH] memcg rcu lock fix v3

On Fri, 23 Apr 2010 14:10:32 +0800
Li Zefan <lizf@...fujitsu.com> wrote:

> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> > 
> > css_id() should be called under rcu_read_lock().
> > Following is a report from Li Zefan.
> > ==
> > ===================================================
> > [ INFO: suspicious rcu_dereference_check() usage. ]
> > ---------------------------------------------------
> > kernel/cgroup.c:4438 invoked rcu_dereference_check() without protection!
> > 
> > other info that might help us debug this:
> > 
> > 
> > rcu_scheduler_active = 1, debug_locks = 1
> > 1 lock held by kswapd0/31:
> >  #0:  (swap_lock){+.+.-.}, at: [<c05058bb>] swap_info_get+0x4b/0xd0
> > 
> > stack backtrace:
> ...
> > 
> > And css_is_ancestor() should be called under rcu_read_lock().
> > 
> > 
> > Reported-by: Li Zefan <lizf@...fujitsu.com>
> > Cc: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
> > Cc: Balbir Singh <balbir@...ux.vnet.ibm.com>
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> 
> With this patch applied, I did some more test, and no warning was triggered.
> 
> Tested-by: Li Zefan <lizf@...fujitsu.com>
> 
Thank you!.

-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/