lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Apr 2010 15:44:46 +0800 From: Gui Jianfeng <guijianfeng@...fujitsu.com> To: Vivek Goyal <vgoyal@...hat.com>, Jens Axboe <jens.axboe@...cle.com> CC: linux kernel mailing list <linux-kernel@...r.kernel.org>, Divyesh Shah <dpshah@...gle.com>, Nauman Rafique <nauman@...gle.com> Subject: Re: [PATCH] blk-cgroup: config options re-arrangement Vivek Goyal wrote: > This patch fixes few usability and configurability issues. > > o All the cgroup based controller options are configurable from > "Genral Setup/Control Group Support/" menu. blkio is the only exception. > Hence make this option visible in above menu and make it configurable from > there to bring it inline with rest of the cgroup based controllers. > > o Get rid of CONFIG_DEBUG_CFQ_IOSCHED. > > This option currently does two things. > > - Enable printing of cgroup paths in blktrace > - Enables CONFIG_DEBUG_BLK_CGROUP, which in turn displays additional stat > files in cgroup. > > If we are using group scheduling, blktrace data is of not really much use > if cgroup information is not present. To get this data, currently one has to > also enable CONFIG_DEBUG_CFQ_IOSCHED, which in turn brings the overhead of > all the additional debug stat files which is not desired. > > Hence, this patch moves printing of cgroup paths under > CONFIG_CFQ_GROUP_IOSCHED. > > This allows us to get rid of CONFIG_DEBUG_CFQ_IOSCHED completely. Now all > the debug stat files are controlled only by CONFIG_DEBUG_BLK_CGROUP which > can be enabled through config menu. > > Signed-off-by: Vivek Goyal <vgoyal@...hat.com> This patch looks good to me. Reviewed-by: Gui Jianfeng <guijianfeng@...fujitsu.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists