| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Apr 2010 10:13:56 +0200 From: Jean Delvare <khali@...ux-fr.org> To: Farid Hammane <farid.hammane@...il.com> Cc: Wolfram Sang <w.sang@...gutronix.de>, ben-linux@...ff.org, Enrik.Berkhan@...com, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] i2c-algo-pca: fix all coding style issues in i2c-algo-pca.c Hi Farid, On Thu, 22 Apr 2010 23:30:34 +0200, Farid Hammane wrote: > Hi Jean and Wolfram, > > On Thursday 22 April 2010 09:59:37 you wrote: > > On Thu, Apr 22, 2010 at 09:25:24AM +0200, Jean Delvare wrote: > > > On Thu, 22 Apr 2010 01:57:38 +0200, Wolfram Sang wrote: > > > > Hi Farid, > > > > > > > > thanks for this approach. Have you checked that the binary is the same > > > > before/after your patch? If so, please mention in your patch > > > > description. > > Ok, I think that nothing can be broken with this kind of patch. I just built > i2c-algo-pca.c and everything was ok. > > For further patchs I will mention that it has been tested. Thanks for the > advice ! It's not just a matter of building it. When you only fix coding style issue, the binary object before and after your patch should be exactly the same. It's a good idea to verify this, especially for drivers you aren't using yourself. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists