linux-kernel - Re: [PATCH] iio-trig-gpio:Remove redundant gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100422233741.GA4414@kroah.com>
Date:	Thu, 22 Apr 2010 16:37:41 -0700
From:	Greg KH <greg@...ah.com>
To:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
Cc:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"uclinux-dist-devel@...ckfin.uclinux.org" 
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	Jonathan Cameron <jic23@....ac.uk>
Subject: Re: [PATCH] iio-trig-gpio:Remove redundant gpio_request

On Tue, Mar 09, 2010 at 12:58:29PM +0000, Hennerich, Michael wrote:
> 
> Remove redundant gpio_request:
> The GPIO used as trigger IRQ, is also requested as gpio, but actually never read.
> 
> Use platform resource facility to get IRQs numbers and flags.
> Make sure this driver can be used with any system IRQ, not necessarily limited to GPIO-IRQs.
> Use dev_err(dev...) and friends instead of printk(KERN_ERR...)
> 
> 
> Signed-off-by: Michael Hennerich <Michael.Hennerich@...log.com>
> Acked-by: Jonathan Cameron <jic23@....ac.uk>
> 
> 
> Index: drivers/staging/iio/trigger/iio-trig-gpio.c
> ===================================================================
> --- drivers/staging/iio/trigger/iio-trig-gpio.c (revision 7916)
> +++ drivers/staging/iio/trigger/iio-trig-gpio.c (working copy)
> @@ -13,7 +13,6 @@
>   * TODO:
>   *
>   * Add board config elements to allow specification of startup settings.
> - * Add configuration settings (irq type etc)
>   */
> 
>  #include <linux/kernel.h>
> @@ -30,7 +29,7 @@
> 
>  struct iio_gpio_trigger_info {
>         struct mutex in_use;
> -       int gpio;
> +       unsigned int irq;

Your email client turned the tabs into spaces, and made this patch
unappliable.  Can you fix this and resend your other patches as well
(they also had the same problem.)

Take a look at Documentation/SubmittingPatches for how to do this
correctly (you also need to make the diff one level down).

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/