linux-kernel - Re: [PATCH] gpio: max732x: fix input configuration for open-drain pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53798eb0b7ee483000fcd94fb76af377@localhost>
Date:	Fri, 23 Apr 2010 15:37:43 +0200
From:	Marc Zyngier <maz@...terjones.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Eric Miao <eric.y.miao@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: max732x: fix input configuration for open-drain pins

On Tue, 20 Apr 2010 16:51:48 -0700, Andrew Morton
<akpm@...ux-foundation.org> wrote:
>> On Tue, 16 Mar 2010 10:19:00 +0100
> 
> I bet you thought I'd forgotten.

Naaaah... I trust your memory more than mine... ;-)

> You really did mean `&' here, but one very much expects a variable
> called is_foo to be a boolean, and booleans want `&&'.

Actually, the attached patch is a much simpler solution to this particular
one. We already checked that the pin is input-capable. Use the same mask to
check that the pin is also output-capable, and thus open-drain. No need for
an additional variable.

Thanks,

        M.
-- 
Who you jivin' with that Cosmik Debris?
Content of type "text/plain" skipped