linux-kernel - Re: [PATCH] add usb_add_bus() function for usb bus list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 Apr 2010 08:03:55 -0700
From:	Greg KH <gregkh@...e.de>
To:	Tomohiro Kusumi <kusumi.tomohiro@...fujitsu.com>
Cc:	linux-usb@...r.kernel.org, stern@...land.harvard.edu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] add usb_add_bus() function for usb bus list

On Fri, Apr 23, 2010 at 02:45:45PM +0900, Tomohiro Kusumi wrote:
> Hi,
> 
> This patch makes usbcore driver sort usb bus on the usb_bus_list by busnum when
> registering a new bus instance.

No one should care about this.

> In current implementation a new bus instance is simply added in front of existing busses.
> Although there is nothing wrong with it in kernel code, reloading HCD may break bus order
> of /proc/bus/usb/devices as it makes usbcore re-register the bus to the list as shown in
> the example below. and it doesn't look good or it may confuse some users.

How does it confuse anyone?  (also note that /proc/bus/usb/devices is
not used in modern distros, it's in a different location now.)

Why not fix your tools to report things in the correct order if you
really care about it?  The bus number means nothing except a unique id,
it does not matter if things are sorted or not in the debug file.

Actually, in the lsusb-rewrite I am doing, the userspace tool does the
sorting, no need to change the kernel.

So, sorry, I'm not going to accept this change.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/