linux-kernel - Re: [PATCH 06/10] ARM: ftrace: add Thumb-2 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1272037066.15107.58.camel@e102109-lin.cambridge.arm.com>
Date:	Fri, 23 Apr 2010 16:37:46 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Rabin Vincent <rabin@....in>
Cc:	linux-kernel@...r.kernel.org,
	Abhishek Sagar <sagar.abhishek@...il.com>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 06/10] ARM: ftrace: add Thumb-2 support

On Wed, 2010-03-31 at 19:25 +0100, Rabin Vincent wrote:
> From bf828a0c069b1bb3f6bf4e68f1dceecab396c286 Mon Sep 17 00:00:00 2001
> From: Rabin Vincent <rabin@....in>
> Date: Sun, 14 Feb 2010 01:18:34 +0530
> Subject: [PATCH 06/10] ARM: ftrace: add Thumb-2 support
> 
> Fix the mcount routines to build and run on a kernel built with the
> Thumb-2 instruction set by correcting the following errors using the
> fixes suggested by Catalin Marinas:
> 
>  - Problem: The following assembler errors appear at the "adr r0,
>    ftrace_stub" instruction:
> 
>    entry-common.S: Assembler messages:
>    entry-common.S:179: Error: invalid immediate for address calculation (value = 0x00000004)
> 
>    Fix: The errors don't occur with a non-global symbol, so use one.
> 
>  - Problem: The "mov lr, pc" does not set the lsb when storing the pc in
>    lr.  The called function returns with "bx lr", and the mode changes
>    to ARM.
> 
>    Fix: Add a label on the return address and use "adr lr, BSYM(label)".
> 
> We don't modify the old mcount because it won't be built when using
> Thumb-2.
> 
> Cc: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Rabin Vincent <rabin@....in>

Acked-by: Catalin Marinas <catalin.marinas@....com>

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/