linux-kernel - Re: USBIP (staging) driver's dependency on drivers/usb/core internal headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100423161455.GA21129@kroah.com>
Date:	Fri, 23 Apr 2010 09:14:55 -0700
From:	Greg KH <greg@...ah.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Eric Lescouet <Eric.Lescouet@...tualLogix.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-usb@...r.kernel.org
Subject: Re: USBIP (staging) driver's dependency on drivers/usb/core
 internal headers

On Fri, Apr 23, 2010 at 11:52:26AM -0400, Alan Stern wrote:
> On Fri, 23 Apr 2010, Greg KH wrote:
> 
> > On Fri, Apr 23, 2010 at 12:44:11PM +0200, Eric Lescouet wrote:
> > > Hi,
> > >
> > > The USBIP modules (and some others) have a direct dependency on the following headers:
> > > - drivers/usb/core/hdc.h (struct usb_hcd and various routines)
> > > - drivers/usb/core/hub.h (couple of constants)
> > > Because those headers are not part of include/, it makes it quite difficult
> > > to compile them as standalone modules (e.g.: against pre-compiled kernel).
> > 
> > Then don't do that :)
> > 
> > > hdc.c and hub.c are relatively self-contained and could be moved to e.g.: include/linux/usb/.
> > >
> > > What do you think?
> > 
> > I think the code needs to be cleaned up and merged to the main part of
> > the kernel tree, then this wouldn't be an issue, right?
> 
> I think moving hub.h into include/linux/usb would be a good thing.  
> However, if this is done then the file contents should be rearranged 
> slightly:
> 
> 	Everything from the "Hub request types" comment through the
> 	various HUB_TTTT_* definitions (except the line declaring
> 	struct usb_device) should be extracted into a separate file.
> 	This new file could be called ch11.h (because it contains 
> 	constants and structures from Chapter 11 of the USB 2.0 spec, 
> 	just as ch9.h contains information from Chapter 9) or it
> 	could keep the name hub.h.  It could even be exported as
> 	a userspace header file.
> 
> 	The remainder (not very much) should be merged into hcd.h.
> 
> Once that's done, moving hcd.h into include/linux/usb would be a 
> reasonable thing to do as well.  It is shared between usbcore and the 
> HCDs, so it really does belong in a more public location.

Ok, fair enough.  Patches are always welcome :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/