linux-kernel - Re: USBIP (staging) driver's dependency on drivers/usb/core internal headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1004231246440.1777-100000@iolanthe.rowland.org>
Date:	Fri, 23 Apr 2010 12:50:21 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Eric Lescouet <Eric.Lescouet@...tualLogix.com>
cc:	Greg KH <greg@...ah.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: USBIP (staging) driver's dependency on drivers/usb/core internal
 headers

On Fri, 23 Apr 2010, Eric Lescouet wrote:

> If I understand correctly, splitting hub.h into hub.h + ch11.h is 
> independent of the move. At the end the 2 (or 3 files) would end up
> into include/linux/usb/.
> correct?

Two files.  The first would be ch11.h (or maybe keep the name hub.h; 
I'm not sure which is best), and the second would be hcd.h (including 
the leftover parts from the original hub.h).

> I've tried to move hub.h and hcd.h and to compile the kernel, already.
> Changing the path of the #include directives in ~40 files did the trick.
> 
> Would you like 2 patches (move and then split) or only 1?

If it weren't for the rename, I'd say do it in two patches.  But if the 
name is changed to ch11.h then those 40 files would have to be altered 
twice.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/