linux-kernel - Re: [PATCH 1/2] Make WMI be selected automatically when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BD1FA5A.6060406@tremplin-utc.net>
Date:	Fri, 23 Apr 2010 21:51:54 +0200
From:	Éric Piel <Eric.Piel@...mplin-utc.net>
To:	Matthew Garrett <mjg59@...f.ucam.org>
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	platform-driver-x86@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	"Brown, Len" <len.brown@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Make WMI be selected automatically when needed

Op 23-04-10 21:20, Matthew Garrett schreef:
> On Sat, Apr 17, 2010 at 02:58:29AM +0200, Éric Piel wrote:
> 
>>  config LEDS_DELL_NETBOOKS
>>  	tristate "External LED on Dell Business Netbooks"
>> -	depends on X86 && ACPI_WMI
>> +	depends on X86
>> +	depends on ACPI
>> +	select ACPI_WMI
> 
> I dislike this. The originally stated dependencies are correct and more 
> accurately represent what the code requires, and changing that for the 
> sake of making it easier for people to find the driver sounds like it's 
> trying to cover up shortcomings in our configuration system more than 
> anything else.
> 
Currently there are 2 modules which select ACPI_WMI and 4 which depend
on it. There are 7 modules which select BACKLIGHT_CLASS_DEVICE and as
many which depend on it. Making usage of the select functionality all
the time would avoid these inconsistencies.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/