linux-kernel - [PATCH 09/11] staging: crystalhd: clean up crystalhd_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100425224209.954e3140.yuasa@linux-mips.org>
Date:	Sun, 25 Apr 2010 22:42:09 +0900
From:	Yoichi Yuasa <yuasa@...ux-mips.org>
To:	Greg Kroah-Hartman <greg@...ah.com>
Cc:	yuasa@...ux-mips.org, Naren Sankar <nsankar@...adcom.com>,
	Jarod Wilson <jarod@...sonet.com>,
	Scott Davilla <davilla@....com>,
	Manu Abraham <abraham.manu@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 09/11] staging: crystalhd: clean up
 crystalhd_put_ddr2sleep() return code

Signed-off-by: Yoichi Yuasa <yuasa@...ux-mips.org>
---
 drivers/staging/crystalhd/crystalhd_hw.c |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c
index 01819d3..4e4d271 100644
--- a/drivers/staging/crystalhd/crystalhd_hw.c
+++ b/drivers/staging/crystalhd/crystalhd_hw.c
@@ -1565,7 +1565,7 @@ static BC_STATUS crystalhd_fw_cmd_post_proc(struct crystalhd_hw *hw,
 	return sts;
 }
 
-static BC_STATUS crystalhd_put_ddr2sleep(struct crystalhd_hw *hw)
+static void crystalhd_put_ddr2sleep(struct crystalhd_hw *hw)
 {
 	uint32_t reg;
 	link_misc_perst_decoder_ctrl rst_cntrl_reg;
@@ -1618,8 +1618,6 @@ static BC_STATUS crystalhd_put_ddr2sleep(struct crystalhd_hw *hw)
 	reg = bc_dec_reg_rd(hw->adp, DecHt_PllBCtl);
 	reg |= 0x00008000;
 	bc_dec_reg_wr(hw->adp, DecHt_PllBCtl, reg);
-
-	return BC_STS_SUCCESS;
 }
 
 /************************************************
@@ -2289,18 +2287,12 @@ BC_STATUS crystalhd_hw_unpause(struct crystalhd_hw *hw)
 
 BC_STATUS crystalhd_hw_suspend(struct crystalhd_hw *hw)
 {
-	BC_STATUS sts;
-
 	if (!hw) {
 		BCMLOG_ERR("Invalid Arguments\n");
 		return BC_STS_INV_ARG;
 	}
 
-	sts = crystalhd_put_ddr2sleep(hw);
-	if (sts != BC_STS_SUCCESS) {
-		BCMLOG_ERR("Failed to Put DDR To Sleep!!\n");
-		return BC_STS_ERROR;
-	}
+	crystalhd_put_ddr2sleep(hw);
 
 	if (!crystalhd_stop_device(hw->adp)) {
 		BCMLOG_ERR("Failed to Stop Device!!\n");
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/