linux-kernel - Re: [PATCH 1/1][BUG][TAKE2] KEYRINGS: find_keyring_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32722.1272293268@redhat.com>
Date:	Mon, 26 Apr 2010 15:47:48 +0100
From:	David Howells <dhowells@...hat.com>
To:	Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
Cc:	dhowells@...hat.com, keyrings@...ux-nfs.org, security@...nel.org,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1][BUG][TAKE2] KEYRINGS: find_keyring_by_name() can gain the freed keyring

Toshiyuki Okajima <toshi.okajima@...fujitsu.com> wrote:

> OK. I understand. So, your patch looks fine to me.
> ---
> Once find_keyring_by_name() returns -ENOKEY, the new user creates a
> new key. So, both the deleting key and the new key may exist.
> Therefore at next find_keyring_by_name() call, we should find the new
> key and ignore the deleting key.
> ---
> 
> Today, I tested your patch and any problem didn't happen.
> So, I rewrote your patch. Here you are:

Thanks.

Note that the vertical lines in the right-hand column of your timeline don't
seem to line up correctly.  Are you editing it in an editor with a
proportional font?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/