linux-kernel - Re: [PATCH] Staging: comedi: fixed coding style issues in drivers.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 25 Apr 2010 22:01:00 -0700
From:	Joe Perches <joe@...ches.com>
To:	zr.public@...il.com
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fixed coding style issues in drivers.c

On Sun, 2010-04-25 at 09:58 -0400, zr.public@...il.com wrote:
> From: Zachary_r <zr.public@...il.com>
> @@ -123,8 +123,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  
>  	for (driv = comedi_drivers; driv; driv = driv->next) {
>  		if (!try_module_get(driv->module)) {
> -			printk
> -			    ("comedi: failed to increment module count, skipping\n");
> +			printk(KERN_INFO "comedi: failed to increment\
> +			module count, skipping\n");

Using line continuations like this is incorrect.
There are many uses like this in your proposed patch.

It adds the initial whitespace on the continued line
to the string constant.

Except for macro definitions, linux doesn't generally
use line continuations.

There's no attempt to keep line numbers consistent
across multiple versions.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/