linux-kernel - Re: [PATCH] drivers:staging: sources for ST core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100426230352.1564ef0f@lxorguk.ukuu.org.uk>
Date:	Mon, 26 Apr 2010 23:03:52 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	pavan_savoy@...com
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org, npelly@...gle.com,
	pavan_savoy@...oo.co.in
Subject: Re: [PATCH] drivers:staging: sources for ST core


> +/* function pointer pointing to either,
> + * st_kim_recv during registration to receive fw download responses
> + * st_int_recv after registration to receive proto stack responses
> + */
> +void (*st_recv) (void*, const unsigned char*, long);

You still need a context of some kind as I said before to avoid thse
globals and single device limits.

And all the other issues - no explanation of the locking etc don't seem
to have been touched either.

I don't really see how I am supposed to review this stuff when the
locking and flow control assumptions are completely opaque

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/