linux-kernel - Re: [PATCH] KEYS: The request_key() syscall should link an existing key to the dest keyring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100426160918.6f624d86.akpm@linux-foundation.org>
Date:	Mon, 26 Apr 2010 16:09:18 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...ux-foundation.org, keyrings@...ux-nfs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KEYS: The request_key() syscall should link an existing
 key to the dest keyring

On Mon, 26 Apr 2010 16:44:41 +0100
David Howells <dhowells@...hat.com> wrote:

> The request_key() system call and request_key_and_link() should make a link
> from an existing key to the destination keyring (if supplied), not just from a
> new key to the destination keyring.
> 
> This can be tested by:
> 
> 	ring=`keyctl newring fred @s`
> 	keyctl request2 user debug:a a
> 	keyctl request user debug:a $ring
> 	keyctl list $ring
> 
> If it says:
> 
> 	keyring is empty
> 
> then it didn't work.  If it shows something like:
> 
> 	1 key in keyring:
> 	1070462727: --alswrv     0     0 user: debug:a
> 
> then it did.
> 

I don't think I understand that description.  Are you saying that the
patch switches things from the first example output into the second case?

Is the fix needed in -stable?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/