| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Apr 2010 14:09:01 +0400 From: Anton Vorontsov <cbouatmailru@...il.com> To: Ryan Mallon <ryan@...ewatersys.com> Cc: Mike Rapoport <mike@...pulab.co.il>, linux-kernel@...r.kernel.org, Yulia Vilensky <vilensky@...pulab.co.il> Subject: Re: [PATCH] ds2782_battery: add support for ds2786 battery gas gauge On Mon, Apr 26, 2010 at 08:44:36AM +1200, Ryan Mallon wrote: [...] > >>> config BATTERY_DS2782 > >>> - tristate "DS2782 standalone gas-gauge" > >>> + tristate "DS2782/DS2786 standalone gas-gauge" > >>> depends on I2C > >>> help > >>> - Say Y here to enable support for the DS2782 standalone battery > >>> + Say Y here to enable support for the DS2782/DS2786 standalone > >>> battery > >> > >> I have only used the DS2782 chip. Can we just change this to DS278x? May > >> as well change to CONFIG_BATTERY_DS278x while we are here. > >> > > > > Shall we move ds2782_battery.c to ds278x_battery.c at the same time? > > Changing Kconfig invites the .c file move as well :) > > Yes. Are there other gas-gauges in the same family? Please don't, this is an unneeded churn. I'd won't bother with renaming Kconfig symbol as well (and btw, that renaming will break oldconfig, so I strongly suggest not to do it). So, your current approch of changing the description and help text is OK. Thanks, -- Anton Vorontsov email: cbouatmailru@...il.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists