linux-kernel - Re: [PATCHv6 4/4] tracing: graph output support for preemptirqsoff/preemptoff tracers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1272332143.9739.39.camel@gandalf.stny.rr.com>
Date:	Mon, 26 Apr 2010 21:35:43 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	mingo@...e.hu, fweisbec@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv6 4/4] tracing: graph output support for
 preemptirqsoff/preemptoff tracers

On Fri, 2010-04-02 at 19:01 +0200, Jiri Olsa wrote:
> hi,
> 
> adding support for graph output for preemptirqsoff/preemptoff tracers.
> 

So far I like the series. But I'm confused why this patch is separate
from patch 3. Is there some reason for it?

If not, I'll just merge this into patch 3

-- Steve

> wbr,
> jirka
> 
> 
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> ---
>  kernel/trace/trace_irqsoff.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
> index cc20d7c..6fd486e 100644
> --- a/kernel/trace/trace_irqsoff.c
> +++ b/kernel/trace/trace_irqsoff.c
> @@ -672,9 +672,15 @@ static struct tracer preemptoff_tracer __read_mostly =
>  	.start		= irqsoff_tracer_start,
>  	.stop		= irqsoff_tracer_stop,
>  	.print_max	= 1,
> +	.print_header   = irqsoff_print_header,
> +	.print_line     = irqsoff_print_line,
> +	.flags		= &tracer_flags,
> +	.set_flag	= irqsoff_set_flag,
>  #ifdef CONFIG_FTRACE_SELFTEST
>  	.selftest    = trace_selftest_startup_preemptoff,
>  #endif
> +	.open		= irqsoff_trace_open,
> +	.close		= irqsoff_trace_close,
>  };
>  # define register_preemptoff(trace) register_tracer(&trace)
>  #else
> @@ -700,9 +706,15 @@ static struct tracer preemptirqsoff_tracer __read_mostly =
>  	.start		= irqsoff_tracer_start,
>  	.stop		= irqsoff_tracer_stop,
>  	.print_max	= 1,
> +	.print_header   = irqsoff_print_header,
> +	.print_line     = irqsoff_print_line,
> +	.flags		= &tracer_flags,
> +	.set_flag	= irqsoff_set_flag,
>  #ifdef CONFIG_FTRACE_SELFTEST
>  	.selftest    = trace_selftest_startup_preemptirqsoff,
>  #endif
> +	.open		= irqsoff_trace_open,
> +	.close		= irqsoff_trace_close,
>  };
>  
>  # define register_preemptirqsoff(trace) register_tracer(&trace)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/