[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100427162745.GA18832@amd.com>
Date: Tue, 27 Apr 2010 18:27:45 +0200
From: Joerg Roedel <joerg.roedel@....com>
To: Avi Kivity <avi@...hat.com>
CC: Marcelo Tosatti <mtosatti@...hat.com>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 15/22] KVM: MMU: Introduce kvm_read_guest_page_x86()
On Tue, Apr 27, 2010 at 07:09:37PM +0300, Avi Kivity wrote:
> On 04/27/2010 06:40 PM, Joerg Roedel wrote:
> >
> >Currently its a bit unclear when to use mmu or nested_mmu. With a
> >pointer it would be unclear to the code reader when to use the pointer
> >and when to select the mmu_contexts directly.
>
> I think in most cases you'd want full translation, thus the pointer.
> This should be the default. In specific cases you'd want just the
> non-nested guest translation.
Hmm, for most cases == all gva_to_gpa cases. The page fault path can't
use the pointer. I'll try out how this works. It shouldn't be too
complicated.
Joerg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists