linux-kernel - Re: [PATCH] ACPI: fix fan module removal when ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100427171854.GE1493@holoscopio.com>
Date:	Tue, 27 Apr 2010 14:18:55 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Len Brown <lenb@...nel.org>
Cc:	linux-acpi@...r.kernel.org, rui.zhang@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: fix fan module removal when ACPI_PROCFS is
 disabled

On Tue, Apr 27, 2010 at 01:12:49PM -0400, Len Brown wrote:
> > When ACPI_PROCFS is disabled, /proc/acpi/fan/ directory is not created.
> > So, it should not be removed during the module removal either.
> 
> Yes, this patch would make the #ifdefs consistent.
> But it looks like remove_proc_entry() just silently does nothing
> if the directory is not there, yes?
> 

No, I get a WARNING right now. That's why I hit the problem, I've just
randomly removed fan.

> What I'd really like to see is a patch removing fan.c's proc code 
> completely.  It was scheduld for removal in July 2008.
> 

Well, no config for "old fan /proc files"? Simply drop it? If that's OK,
I'll gladly submit another patch.

> thanks,
> Len Brown, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)