linux-kernel - Re: [PATCH] lockdep: Fix redundant_hardirqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100427180749.GB5586@nowhere>
Date:	Tue, 27 Apr 2010 20:07:56 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	David Miller <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH] lockdep: Fix redundant_hardirqs_on incremented with
	irqs enabled

On Tue, Apr 27, 2010 at 05:32:27PM +1000, Stephen Rothwell wrote:
> Hi Frederic,
> 
> On Thu, 15 Apr 2010 15:37:50 +0200 Frederic Weisbecker <fweisbec@...il.com> wrote:
> >
> > When a path restore the flags while irqs are already enabled, we
> > update the per cpu var redundant_hardirqs_on in a racy fashion
> > and debug_atomic_inc() warns about this situation.
> > 
> > In this particular case, we need to explictly disable the irqs before
> > updating this stat var in order to update it safely.
> > 
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: David Miller <davem@...emloft.net>
> > Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> > ---
> >  kernel/lockdep.c |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> Ping?  Any movement on this?


Ingo, if you have no problems with these two patches, could you please
apply them?

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/