linux-kernel - Re: [PATCH 2/2] Staging:dt3155: fix coding style issue in dt3155_drv.c This is a patch to the dt3155_drv.c file that fixes up a coding style warning and errors found by the checkpatch.pl tool;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100427210029.GB5046@kroah.com>
Date:	Tue, 27 Apr 2010 14:00:29 -0700
From:	Greg KH <greg@...ah.com>
To:	Gorskin Ilya <revent82@...il.com>
Cc:	gregkh@...e.de, hsweeten@...ionengravers.com, ss@....gov.au,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging:dt3155: fix coding style issue in
 dt3155_drv.c This is a patch to the dt3155_drv.c file that fixes up a
 coding style warning and errors found by the checkpatch.pl tool;

On Sat, Mar 13, 2010 at 01:34:37PM +0500, Gorskin Ilya wrote:
> @@ -183,241 +183,215 @@ static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs )
>    u32 buffer_addr;
>  
>    /* find out who issued the interrupt */
> -  for ( index = 0; index < ndevices; index++ ) {
> -    if( dev_id == (void*) &dt3155_status[ index ])
> -      {
> -	minor = index;
> +    for (index = 0; index < ndevices; index++) {
> +	if (dev_id == (void *) &dt3155_status[index]) {
> +		minor = index;

This fixes up the {} usage, but not the tabs/spaces issues, so it is
still incorrect.  Can you fix that up at the same time here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/