linux-kernel - Re: [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100427.152236.73676344.davem@davemloft.net>
Date:	Tue, 27 Apr 2010 15:22:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	linux-kernel@...r.kernel.org, mpm@...enic.com,
	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	gospo@...hat.com, nhorman@...driver.com, jmoyer@...hat.com,
	shemminger@...ux-foundation.org,
	bonding-devel@...ts.sourceforge.net, fubar@...ibm.com
Subject: Re: [v4 Patch 1/3] netpoll: add generic support for bridge and
 bonding devices

From: Amerigo Wang <amwang@...hat.com>
Date: Tue, 27 Apr 2010 03:55:41 -0400

> +	if (ndev->priv_flags & IFF_DISABLE_NETPOLL
> +			|| !ndev->netdev_ops->ndo_poll_controller) {

" ||" goes on first line, not second, and second line needs to be indented
properly so that "!ndev->..." matches up with "ndev->priv_flags ..." on
the previous line.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/