linux-kernel - Re: [PATCH v2] XFS: Let the broken fiemap work in query mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100428113359.GB27769@infradead.org>
Date:	Wed, 28 Apr 2010 07:33:59 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Tao Ma <tao.ma@...cle.com>
Cc:	linux-kernel@...r.kernel.org, Eric Sandeen <sandeen@...hat.com>,
	xfs@....sgi.com, Alex Elder <aelder@....com>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2] XFS: Let the broken fiemap work in query mode.

On Wed, Apr 28, 2010 at 11:00:25AM +0800, Tao Ma wrote:
> -	bm.bmv_count = fieinfo->fi_extents_max + 1;
> +	bm.bmv_count = !fieinfo->fi_extents_max ? MAXEXTNUM :
> +					fieinfo->fi_extents_max + 1;
> +	bm.bmv_count = MIN(bm.bmv_count,
> +			   (__s32)(PAGE_SIZE * 16 / sizeof(struct getbmapx)));

I would use min_t here instead of the case, but otherwise the patch
looks good to me,


Reviewed-by: Christoph Hellwig <hch@....de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/