linux-kernel - Re: HID: expand hid-topseed driver to support BTC "Emprex 3009URF III Vista MCE Remote"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1004281349130.9849@pobox.suse.cz>
Date:	Wed, 28 Apr 2010 13:51:22 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Wayne Thomas <waynethomas69@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: HID: expand hid-topseed driver to support BTC "Emprex 3009URF
 III  Vista MCE Remote"

On Wed, 28 Apr 2010, Wayne Thomas wrote:

> >> OK, next attempt...
> >
> > The patch is OK, but your mail client whitespace-damaged it. Could you
> > please fix up your client and resend? (or attach it separately as an
> > attachment, if your client can't be fixed).
> >
> > Thanks,
> 
> I thought it might have; sorry about that.
> Have attached patch as separate file as a precaution.

Thanks for the patch.

What is the reason for it being backwards-compatible with the older 
topspeed device?

Changes such as

-	case 0x048: ts_map_key_clear(KEY_RED);            break;
+	case 0x05b: ts_map_key_clear(KEY_RED);          break;

(and no other handling of neither 0x048 nor KEY_RED) make me wonder ...

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/