linux-kernel - USB_SERIAL_KEYSPAN_* dependency on FIRMWARE_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Apr 2010 23:24:27 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: USB_SERIAL_KEYSPAN_* dependency on FIRMWARE_IN_KERNEL

Hi David,

I recently disabled CONFIG_FIRMWARE_IN_KERNEL in the default openSUSE
kernels (as no built-in driver needs firmware and the initrd takes care
of the modules), but this disabled all the CONFIG_USB_SERIAL_KEYSPAN_*
options, because there is

config USB_SERIAL_KEYSPAN_MPR
        bool "USB Keyspan MPR Firmware"
        depends on USB_SERIAL_KEYSPAN && FIRMWARE_IN_KERNEL
etc

in drivers/usb/serial/Kconfig, added in 2971c57 by you. Is there a
reason for this dependency or shouldn't this rather depend on FW_LOADER?
On a related note, firmware/Makefile has

ifdef CONFIG_FIRMWARE_IN_KERNEL
fw-shipped-$(CONFIG_USB_SERIAL_KEYSPAN_MPR) += keyspan/mpr.fw
...
else
fw-shipped- += keyspan/mpr.fw ...
endif

which just duplicates the dependency (if CONFIG_FIRMWARE_IN_KERNEL is
not set, the CONFIG_USB_SERIAL_KEYSPAN_* options won't be set either).
Note that I do not have the hardware, so maybe I'm missing something
obvious...

thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/