linux-kernel - Re: [PATCH 1/2 v2] MMC:Add support MMCIF for SuperH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Apr 2010 22:17:05 -0400
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Yusuke Goda <yusuke.goda.sx@...esas.com>
Cc:	ben@...adent.org.uk, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH 1/2 v2] MMC:Add support MMCIF for SuperH

On Wed, 28 Apr 2010 14:06:08 +0900 Yusuke Goda <yusuke.goda.sx@...esas.com> wrote:

> +	time = wait_event_interruptible_timeout(host->intr_wait,
> +			host->wait_int == 1 ||
> +			host->sd_error == 1, host->timeout);
> +	if (host->wait_int != 1 && (time == 0 || host->sd_error != 0))
> +		return sh_mmcif_error_manage(host);

wait_event_interruptible_timeout() will return early with -ERESTARTSYS
if the calling process gets signalled (eg, ^C was hit).

The driver uses wait_event_interruptible_timeout() rather a lot and the
two sites I looked at seem to handle the signal_pending() case
correctly.

But incorrectly handling signals with interruptible waits is a
frequently-occurring error in drivers.  Did you deliberately cater for
this case, and have you runtime tested it?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/