linux-kernel - Re: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled files into 1 clean file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Apr 2010 22:34:27 -0700
From:	Greg KH <greg@...ah.com>
To:	Joe Perches <joe@...ches.com>
Cc:	devel@...verdev.osuosl.org, Scott Smedley <ss@....gov.au>,
	Greg KH <gregkh@...e.de>,
	Jason Baldus <jason.baldus@...il.com>,
	linux-kernel@...r.kernel.org,
	Harley Sweeten <hsweeten@...ionengravers.com>,
	Simon Horman <horms@...ge.net.au>
Subject: Re: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled
	files into 1 clean file

On Tue, Apr 27, 2010 at 10:30:03PM -0700, Joe Perches wrote:
> On Tue, 2010-04-27 at 16:02 -0700, Greg KH wrote:
> > On Mon, Mar 29, 2010 at 12:34:28AM -0700, Joe Perches wrote:
> > > Make variables static where appropriate
> > > Rename dt3155_<foo_with_long_names> variables to dt_<foo_tla>
> > > to reduce code length and make more lines fit well in 80 chars
> > > Remove now unnecessary .h files
> > > Change indent to use tabs
> > > Remove unused functions
> > > Used bool more often
> > > Checkpatch clean
> > 
> > This is too much in one patch, sorry.
> 
> You should be more consistent.

I am human.

> http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
> Greg even said, "submit one big patch if you want"

Yes, but I will then help to guide them to make it a more reasonable,
and reviewable, patch :)

> > It also doesn't apply due to
> > other changes in these files (that you then remove in patch 3) from
> > other developers.
> 
> No, it doesn't apply because you chose to apply other patches
> before this one.

Those patches were sent to me before yours, sorry.

thanks,

greg "slowly catching up" k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/