linux-kernel - Re: [PATCH tip/core/urgent] fix several lockdep splats, allow multiple splats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Apr 2010 12:07:49 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, josh@...htriplett.org,
	dvhltc@...ibm.com, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu,
	dhowells@...hat.com, eric.dumazet@...il.com
Subject: Re: [PATCH tip/core/urgent] fix several lockdep splats, allow
 multiple splats

* Paul E. McKenney <paulmck@...ux.vnet.ibm.com> wrote:

> Hello!
> 
> This patchset contains four RCU lockdep splat fixes, courtesy of David 
> Howells, Peter Zijlstra, and Trond Myklebust, [...]

I've applied #1 and #2 - but shouldnt #4 and #5 go via the NFS tree?

> [...] as well as an enhancement by Lai Jiangshan that permits collecting 
> more than one RCU lockdep splat per boot.

Hm, this #3 patch i disagree with quite fundamentally: one of the big virtues 
of lockdep is that it complains only once and then shuts up and lets the 
system work. It allows distro debug kernels to have lockdep enabled, etc.

One bugreport per bootup per user is the most we can expect really. Not 
disabling it risks getting a stream of repeat messages, annoyed testers and 
gives us _less_ bugreports in the end.

Also, often the _first_ warning is the most reliable one - sometimes there's 
interactions, and the first bug causing a second warning as well, etc. So 
reporting just the highest-quality (i.e. first) issue we detect is the best 
approach.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/