linux-kernel - RE: [PATCH] firmware_class: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6F5C1D715B2DA5498A628E6B9C124F04016E6B6959@hasmsx504.ger.corp.intel.com>
Date:	Thu, 29 Apr 2010 21:03:25 +0300
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	David Woodhouse <dwmw2@...radead.org>, Greg KH <gregkh@...e.de>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Johannes Berg <johannes@...solutions.net>,
	Ming Lei <tom.leiming@...il.com>,
	Catalin Marinas <catalin.marinas@....com>
Subject: RE: [PATCH] firmware_class: fix memory leak - free allocated pages



> -----Original Message-----
> From: David Woodhouse [mailto:dwmw2@...radead.org]
> Sent: Thursday, April 29, 2010 8:54 PM
> To: Greg KH
> Cc: Winkler, Tomas; linux-kernel@...r.kernel.org; Johannes Berg; Ming Lei;
> Catalin Marinas
> Subject: Re: [PATCH] firmware_class: fix memory leak - free allocated pages
> 
> On Thu, 2010-04-29 at 15:54 +0100, Greg KH wrote:
> > On Thu, Apr 29, 2010 at 03:40:21PM +0300, Tomas Winkler wrote:
> > > fix memory leak introduced by 6e03a201bbe patch:
> > >  firmware: speed up request_firmware()
> >
> > Who originally wrote this patch, Kay?
> 
> It's kind of a joint effort. I think it's probably mine by a fairly
> narrow majority.
> 
> >  If so, Tomas, please put a "From:" line at the top of the patch with
> > the author's name so we get it right when commiting it.
> 
> And don't make up Signed-off-by lines. Although you can have that one of
> mine now you've got it (since you've actually tested it).

I added firmware_free_data function to the original patch, would you mind to review it, please.

Thanks
Tomas
> 
> --
> David Woodhouse                            Open Source Technology Centre
> David.Woodhouse@...el.com                              Intel Corporation

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.