linux-kernel - Re: Staging: iio: Fix remaining code style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Apr 2010 12:17:34 -0700
From:	Greg KH <greg@...ah.com>
To:	Roel Van Nyen <roel.vannyen@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, sdietrich@...ell.com,
	sonic.adi@...il.com, jic23@....ac.uk, akpm@...ux-foundation.org,
	lindner_marek@...oo.de
Subject: Re: Staging: iio: Fix remaining code style issues

On Thu, Apr 29, 2010 at 07:27:31PM +0200, Roel Van Nyen wrote:
> fix code style issues
> 
> Signed-of-by: Roel Van Nyen <roel.vannyen@...il.com>
> Cc: Jonathan Cameron <jic23@....ac.uk>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -810,7 +810,7 @@ int iio_device_register(struct iio_dev *dev_info)
>  	ret = iio_device_register_eventset(dev_info);
>  	if (ret) {
>  		dev_err(dev_info->dev.parent,
> -			"Failed to register event set \n");
> +			"Failed to register event set\n");
>  		goto error_free_sysfs;
>  	}
>  	if (dev_info->modes & INDIO_RING_TRIGGERED)
> diff --git a/drivers/staging/iio/ring_sw.c b/drivers/staging/iio/ring_sw.c
> index e95b6a4..4981803 100644
> --- a/drivers/staging/iio/ring_sw.c
> +++ b/drivers/staging/iio/ring_sw.c
> @@ -126,8 +126,7 @@ int iio_store_to_sw_ring(struct iio_sw_ring_buffer *ring,
>  		spin_lock(&ring->buf.shared_ev_pointer.lock);
>  
>  		ret = iio_push_or_escallate_ring_event(&ring->buf,
> -						       IIO_EVENT_CODE_RING_100_FULL,
> -						       timestamp);
> +			       IIO_EVENT_CODE_RING_100_FUL, timestamp);

You never tested this fix :(

It breaks the build, please be more careful next time.  I've fixed it
up...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/