linux-kernel - Re: [PATCHv2 3/8] USB: gadget: __init and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d3xhpkdi.fsf@erwin.mina86.com>
Date:	Thu, 29 Apr 2010 22:41:48 -0700 (PDT)
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Greg KH <greg@...ah.com>
Cc:	Michal Nazarewicz <m.nazarewicz@...sung.com>,
	linux-usb@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 3/8] USB: gadget: __init and __exit tags removed

>>> On Fri, Apr 09, 2010 at 09:21:20PM +0200, Michal Nazarewicz wrote:
>>>> @@ -85,7 +85,7 @@ MODULE_PARM_DESC(iSerialNumber, "SerialNumber string");
>>>>   * This function returns the value of the function's bind(), which is
>>>>   * zero for success else a negative errno value.
>>>>   */
>>>> -int __init usb_add_function(struct usb_configuration *config,
>>>> +int __cold usb_add_function(struct usb_configuration *config,

>> Greg KH <greg@...ah.com> writes:
>>> What is the "__cold" for?
 
> On Thu, Apr 29, 2010 at 04:02:55PM -0700, Michal Nazarewicz wrote:
>> __init, among other things implies __cold so I left __cold leaving
>> out __section.

Greg KH <greg@...ah.com> writes:
> Hm, how about just dropping everything?  I don't think we need the
> __cold here then, right?

As you wish.  I'm about to resend the whole patchset (probably today or
Monday) with some new code so I'll include this change as well.

-- 
Best regards,                                         _     _
 .o. | Liege of Serenly Enlightened Majesty of      o' \,=./ `o
 ..o | Computer Science,  Michal "mina86" Nazarewicz   (o o)
 ooo +--<mina86-tlen.pl>--<jid:mina86-jabber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/