linux-kernel - Re: [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BDA7122.6080509@monstr.eu>
Date:	Fri, 30 Apr 2010 07:56:50 +0200
From:	Michal Simek <monstr@...str.eu>
To:	"Steven J. Magnani" <steve@...idescorp.com>
CC:	microblaze-uclinux@...e.uq.edu.au, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][NOMMU] microblaze: re-enable interrupts before calling
 schedule

Steven J. Magnani wrote:
> schedule() should not be called with interrupts disabled.
> 
> Signed-off-by: Steven J. Magnani <steve@...idescorp.com>
> ---
> diff -uprN a/arch/microblaze/kernel/entry-nommu.S b/arch/microblaze/kernel/entry-nommu.S
> --- a/arch/microblaze/kernel/entry-nommu.S	2010-04-27 10:14:33.000000000 -0500
> +++ b/arch/microblaze/kernel/entry-nommu.S	2010-04-27 12:53:04.000000000 -0500
> @@ -476,6 +476,8 @@ ENTRY(ret_from_fork)
>  	nop
>  
>  work_pending:
> +	enable_irq
> +
>  	andi	r11, r19, _TIF_NEED_RESCHED
>  	beqi	r11, 1f
>  	bralid	r15, schedule
> 

Applied

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/