linux-kernel - Re: [PATCH 04/14] vc: Locking clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201004302230.22358.arnd@arndb.de>
Date:	Fri, 30 Apr 2010 22:30:22 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/14] vc: Locking clean up

On Thursday 01 April 2010 18:04:59 Alan Cox wrote:
> @@ -282,7 +282,12 @@ static inline unsigned short *screenpos(struct vc_data *vc, int offset, int view
>  
>  static inline void scrolldelta(int lines)
>  {
> +       lock_kernel();
> +       /* FIXME */
> +       /* scrolldelta needs some kind of consistency lock, but the BKL was
> +          and still is not protecting versus the scheduled back end */
>         scrollback_delta += lines;
> +       unlock_kernel();
>         schedule_console_callback();
>  }
>  

This one triggered a might_sleep() warning in _lock_kernel(), because
it's called from the keyboard interrupt.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/