linux-kernel - Re: [PATCH] intel_txt: enable VMXON check with SMX in KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BDD82EA.7060308@redhat.com>
Date:	Sun, 02 May 2010 16:49:30 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Shane Wang <shane.wang@...el.com>
CC:	hpa@...or.com, mingo@...e.hu, joseph.cihula@...el.com,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH] intel_txt: enable VMXON check with SMX in KVM

On 04/29/2010 07:09 PM, Shane Wang wrote:
> Per document, for feature control MSR
> Bit 1 enables VMXON in SMX operation. If the bit is clear, execution of VMXON in SMX operation causes a general-protection exception.
> Bit 2 enables VMXON outside SMX operation. If the bit is clear, execution of VMXON outside SMX operation causes a general-protection exception.
>
> This patch is to enable this kind of check with SMX for VMXON in KVM.
>
>    

Looks good.

> @@ -1176,9 +1177,16 @@ static __init int vmx_disabled_by_bios(v
>   	u64 msr;
>
>   	rdmsrl(MSR_IA32_FEATURE_CONTROL, msr);
> -	return (msr&  (FEATURE_CONTROL_LOCKED |
> -		       FEATURE_CONTROL_VMXON_ENABLED))
> -	    == FEATURE_CONTROL_LOCKED;
> +	if (!!(msr&  FEATURE_CONTROL_LOCKED)) {
>    

!! not really necessary here (no need to resend, we can fix while applying).

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/