linux-kernel - Re: [BUG: invalid hash] - update pata_pcmcia/ide-cs with transcend and kingston cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100502163711.GA1362@boggieman>
Date:	Sun, 2 May 2010 18:37:11 +0200
From:	Kristoffer Ericson <kristoffer.ericson@...il.com>
To:	Komuro <komurojun-mbn@...ty.com>
Cc:	linux-pcmcia@...ts.infradead.org, linux@...inikbrodowski.net,
	jeff@...zik.org, linux-kernel@...r.kernel.org
Subject: Re: [BUG: invalid hash]  - update pata_pcmcia/ide-cs with
 transcend and kingston cards

On Sun, May 02, 2010 at 08:31:09PM +0900, Komuro wrote:
> Hi,
> 
> The hash of "CF CARD 1GB" and "TS4GCF133" are wrong.
> 
> pcmcia: pata_pcmcia: invalid hash for product string "CF CARD 1GB": is 0x3e520
> e17, should be 0x55d5bffb
> pcmcia: see Documentation/pcmcia/devicetable.txt for details
> pcmcia: pata_pcmcia: invalid hash for product string "TS4GCF133": is 0x9351e59
> d, should be 0x7558f133
> pcmcia: see Documentation/pcmcia/devicetable.txt for details
> 

Ah, must have used the wrong hash settings on my converter for
those. Will post fixup patch shortly. Thanks!

Kristoffer


> >
> >On 04/19/2010 01:54 PM, Kristoffer Ericson wrote:
> >> This patch adds idstrings for Kingston 1GB/4GB and Transcend 4GB/8GB.
> >>
> >> Signed-off-by: Kristoffer Ericson<kristoffer.ericson@...il.com>
> >>
> >> diff --git a/drivers/ide/ide-cs.c b/drivers/ide/ide-cs.c
> >> index ab87e4f..defce28 100644
> >> --- a/drivers/ide/ide-cs.c
> >> +++ b/drivers/ide/ide-cs.c
> >> @@ -409,6 +409,8 @@ static struct pcmcia_device_id ide_ids[] = {
> >>   	PCMCIA_DEVICE_PROD_ID12("Hyperstone", "Model1", 0x3d5b9ef5, 0xca6ab420),
> >>   	PCMCIA_DEVICE_PROD_ID12("IBM", "microdrive", 0xb569a6e5, 0xa6d76178),
> >>   	PCMCIA_DEVICE_PROD_ID12("IBM", "IBM17JSSFP20", 0xb569a6e5, 0xf2508753),
> >> +	PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF CARD 1GB", 0x2e6d1829, 0x3e520e17
> ),
> >> +	PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF CARD 4GB", 0x2e6d1829, 0x531e7d10
> ),
> >>   	PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF8GB", 0x2e6d1829, 0xacbe682e),
> >>   	PCMCIA_DEVICE_PROD_ID12("IO DATA", "CBIDE2      ", 0x547e66dc, 0x8671043
> b),
> >>   	PCMCIA_DEVICE_PROD_ID12("IO DATA", "PCIDE", 0x547e66dc, 0x5c5ab149),
> >> @@ -429,6 +431,8 @@ static struct pcmcia_device_id ide_ids[] = {
> >>   	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1, 0x2a54d4b1)
> ,
> >>   	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1, 0x969aa4f2
> ),
> >>   	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1, 0xf54a91c8
> ),
> >> +	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF133", 0x709b1bf1, 0x9351e59d)
> ,
> >> +	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS8GCF133", 0x709b1bf1, 0xb2f89b47)
> ,
> >>   	PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
> >>   	PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c, 0x212bb918),
> >>   	PCMCIA_DEVICE_PROD_ID1("STI Flash", 0xe4a13209),
> >> diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
> >> index 3c3172d..4164dd2 100644
> >> --- a/drivers/ata/pata_pcmcia.c
> >> +++ b/drivers/ata/pata_pcmcia.c
> >> @@ -424,6 +424,8 @@ static struct pcmcia_device_id pcmcia_devices[] = {
> >>   	PCMCIA_DEVICE_PROD_ID12("Hyperstone", "Model1", 0x3d5b9ef5, 0xca6ab420),
> >>   	PCMCIA_DEVICE_PROD_ID12("IBM", "microdrive", 0xb569a6e5, 0xa6d76178),
> >>   	PCMCIA_DEVICE_PROD_ID12("IBM", "IBM17JSSFP20", 0xb569a6e5, 0xf2508753),
> >> +	PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF CARD 1GB", 0x2e6d1829, 0x3e520e17
> ),
> >> +	PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF CARD 4GB", 0x2e6d1829, 0x531e7d10
> ),
> >>   	PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF8GB", 0x2e6d1829, 0xacbe682e),
> >>   	PCMCIA_DEVICE_PROD_ID12("IO DATA", "CBIDE2      ", 0x547e66dc, 0x8671043
> b),
> >>   	PCMCIA_DEVICE_PROD_ID12("IO DATA", "PCIDE", 0x547e66dc, 0x5c5ab149),
> >> @@ -444,6 +446,8 @@ static struct pcmcia_device_id pcmcia_devices[] = {
> >>   	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1, 0x2a54d4b1)
> ,
> >>   	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1, 0x969aa4f2
> ),
> >>   	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1, 0xf54a91c8
> ),
> >> +	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF133", 0x709b1bf1, 0x9351e59d)
> ,
> >> +	PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS8GCF133", 0x709b1bf1, 0xb2f89b47)
> ,
> >>   	PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
> >>   	PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c, 0x212bb918),
> >>   	PCMCIA_DEVICE_PROD_ID1("STI Flash", 0xe4a13209),
> >>
> 
> Best Regards
> Komuro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/