| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100502201220.GA26113@oksana.dev.rtsoft.ru> Date: Mon, 3 May 2010 00:12:20 +0400 From: Anton Vorontsov <cbouatmailru@...il.com> To: Mike Rapoport <mike.rapoport@...il.com> Cc: Mike Rapoport <mike@...pulab.co.il>, Ryan Mallon <ryan@...ewatersys.com>, linux-kernel@...r.kernel.org, Yulia Vilensky <vilensky@...pulab.co.il> Subject: Re: [PATCH v3] ds2782_battery: add support for ds2786 battery gas gauge On Mon, Apr 26, 2010 at 10:39:41PM +0300, Mike Rapoport wrote: > On Mon, Apr 26, 2010 at 9:22 PM, Anton Vorontsov <cbouatmailru@...il.com> wrote: > > > > Btw, I don't quite like the 'if (id->driver_data == 1)' stuff. > > How about the following patch on top? > > > > From acf917d3880465b76875f671ee450a8fdff62c9f Mon Sep 17 00:00:00 2001 > > From: Anton Vorontsov <cbouatmailru@...il.com> > > Date: Mon, 26 Apr 2010 22:10:52 +0400 > > Subject: [PATCH] ds2782_battery: Get rid of magic numbers in driver_data > > > > Constructions like 'if (id->driver_data == 1)' look quite weird. > > This patch introduces 'enum ds278x_num_id', which makes things > > much more understandable, i.e. 'if (id->driver_data == DS2786)'. > > agree > > > Signed-off-by: Anton Vorontsov <cbouatmailru@...il.com> > > Acked-by: Mike Rapoport <mike@...pulab.co.il> Thanks! Applied. -- Anton Vorontsov email: cbouatmailru@...il.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists