lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 May 2010 13:29:46 +0200 From: Hannes Eder <heder@...gle.com> To: Patrick McHardy <kaber@...sh.net> Cc: Simon Horman <horms@...ge.net.au>, lvs-devel@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, netfilter@...r.kernel.org, Wensong Zhang <wensong@...ux-vs.org>, Julius Volz <julius.volz@...il.com>, "David S. Miller" <davem@...emloft.net>, Netfilter Development Mailinglist <netfilter-devel@...r.kernel.org> Subject: Re: [patch v2.2 1/4] [PATCH v2.1 1/4] netfilter: xt_ipvs (netfilter matcher for IPVS) Thank you for picking this series of patches up again and thanks for the feedback. I'll send an updated version in the next days. Cheers, -Hannes On Sat, May 1, 2010 at 18:18, Patrick McHardy <kaber@...sh.net> wrote: > Simon Horman wrote: > >> @@ -0,0 +1,25 @@ >> +#ifndef _XT_IPVS_H >> +#define _XT_IPVS_H 1 > > You don't need to define a value. > >> +config NETFILTER_XT_MATCH_IPVS >> + tristate '"ipvs" match support' >> + depends on IP_VS >> + depends on NETFILTER_ADVANCED >> + help >> + This option allows you to match against IPVS properties of a packet. >> + >> + If unsure, say N. > > You're using conntrack symbols, so this seems to need a dependency > on NF_CONNTRACK. > >> +static bool ipvs_mt_check(const struct xt_mtchk_param *par) > > We've changed the signature to "int" in nf-next to be able to > return errno codes. Please rebase your patches onto nf-next-2.6.git. > > Please also CC netfilter-devel at least for those parts that affect > non-IPVS netfilter. > >> +{ >> + if (par->family != NFPROTO_IPV4 >> +#ifdef CONFIG_IP_VS_IPV6 >> + && par->family != NFPROTO_IPV6 >> +#endif >> + ) { >> + pr_info("protocol family %u not supported\n", par->family); >> + return false; >> + } >> + >> + return true; >> +} > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists