linux-kernel - [PATCH] perf: Fix performance issue with perf report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100504111915.GB14636@kryten>
Date:	Tue, 4 May 2010 21:19:15 +1000
From:	Anton Blanchard <anton@...ba.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Eric B Munson <ebmunson@...ibm.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] perf: Fix performance issue with perf report


On a large machine we spend a lot of time in perf_header__find_attr when
running perf report. 

If we are parsing a file without PERF_SAMPLE_ID then for each sample we call
perf_header__find_attr and loop through all counter IDs, never finding a match.
As the machine gets larger there are more per cpu counters and we spend an
awful lot of time in there.

The patch below initialises each sample id to -1ULL and checks for this in
perf_header__find_attr. We may need to do something more intelligent eventually
(eg a hash lookup from counter id to attr) but this at least fixes the most
common usage of perf report.

Signed-off-by: Anton Blanchard <anton@...ba.org>
--

Index: linux.trees.git/tools/perf/util/event.c
===================================================================
--- linux.trees.git.orig/tools/perf/util/event.c	2010-05-03 20:20:54.000000000 +1000
+++ linux.trees.git/tools/perf/util/event.c	2010-05-04 21:15:20.000000000 +1000
@@ -713,6 +713,7 @@ int event__parse_sample(event_t *event, 
 		array++;
 	}
 
+	data->id = -1ULL;
 	if (type & PERF_SAMPLE_ID) {
 		data->id = *array;
 		array++;
Index: linux.trees.git/tools/perf/util/header.c
===================================================================
--- linux.trees.git.orig/tools/perf/util/header.c	2010-05-03 20:20:54.000000000 +1000
+++ linux.trees.git/tools/perf/util/header.c	2010-05-04 21:15:20.000000000 +1000
@@ -923,6 +923,14 @@ perf_header__find_attr(u64 id, struct pe
 {
 	int i;
 
+	/*
+	 * We set id to -1 if the data file doesn't contain sample
+	 * ids. Check for this and avoid walking through the entire
+	 * list of ids which may be large.
+	 */
+	if (id == -1ULL)
+		return NULL;
+
 	for (i = 0; i < header->attrs; i++) {
 		struct perf_header_attr *attr = header->attr[i];
 		int j;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/