linux-kernel - Re: [PATCH] hwmon: applesmc: Add temperature sensor labels to sysfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100504133200.34413e2b@hyperion.delvare>
Date:	Tue, 4 May 2010 13:32:00 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org,
	Alex Murray <murray.alex@...il.com>
Subject: Re: [PATCH] hwmon: applesmc: Add temperature sensor labels to sysfs
  interface

On Tue, 04 May 2010 13:15:51 +0200, Henrik Rydberg wrote:
> Jean Delvare wrote:
> [...]
> >> @@ -1578,6 +1717,8 @@ static int __init applesmc_init(void)
> >>  		}
> >>  		ret = sysfs_create_file(&pdev->dev.kobj,
> >>  						temperature_attributes[i]);
> > 
> > Missing error handling.
> > 
> >> +		ret = sysfs_create_file(&pdev->dev.kobj,
> >> +						label_attributes[i]);
> >>  		if (ret)
> >>  			goto out_temperature;
> >>  	}
> >
> 
> Shoot, my bad review. Will send a new patch. While at it, the same function
> seems to leak fan attribute groups. Want me to correct such issues (in another
> patch)?

Yes please. As a bugfix, that would even be a candidate for 2.6.34. I
have another patch (for asc7621) pending already.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/