linux-kernel - Re: [PATCH] Oprofile: Change CPUIDS from decimal to hex, and add some comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100504140328.GB6450@erda.amd.com>
Date:	Tue, 4 May 2010 16:03:28 +0200
From:	Robert Richter <robert.richter@....com>
To:	John Villalovos <sodarock@...il.com>
CC:	andi@...stfloor.org, linux-kernel@...r.kernel.org, x86@...nel.org,
	oprofile-list@...ts.sf.net
Subject: Re: [PATCH] Oprofile: Change CPUIDS from decimal to hex, and add
 some comments

On 16.04.10 13:08:49, John Villalovos wrote:
> Back when the patch was submitted for "Add Xeon 7500 series support to
> oprofile", Robert Richter had asked for a follown patch that converted
> all the CPU ID values to hex.
> 
> I have done that here for the processors in the ppro_init() function and also
> added some documentation as comments that I retrieved from the Intel Software
> Developer's Manual (SDM) March 2010 edition in Volume 3B, Table B-1.
> 
> The Intel SDM can be found at:
> http://www.intel.com/products/processor/manuals/
> 
> I also added processor codenames for some of the newer processors.

John,

I don't want to change previous cpu models and keep it as it is. So I
am fine with updating i386/core_i7 and i386/atom to avoid mixed dec
and hex notations.

Please also remove the comments that describe the model as it will be
hard to maintain this, if there are questions one should read the
spec. So please also add some more details of the specification source
to the patch description, I think it is:

 Table B-1. CPUID Signature Values of DisplayFamily_DisplayModel

in SDM Volume 3B.

Use lower case hex values instead.

Add your Signed-off-by please.

Thanks,

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@....com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/