linux-kernel - Re: Patch for wlan-ng/hfa384x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100504154914.GA24737@kroah.com>
Date:	Tue, 4 May 2010 08:49:14 -0700
From:	Greg KH <greg@...ah.com>
To:	Joe Perches <joe@...ches.com>
Cc:	adam.latham@...sontorbay.org.uk, devel@...verdev.osuosl.org,
	Jiri Kosina <jkosina@...e.cz>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Andrew Elwell <Andrew.Elwell@...il.com>,
	linux-kernel@...r.kernel.org, Svenne Krap <svenne@...p.dk>
Subject: Re: Patch for wlan-ng/hfa384x_usb.c

On Mon, May 03, 2010 at 12:33:30PM -0700, Joe Perches wrote:
> On Mon, 2010-05-03 at 19:30 +0100, Adam Latham wrote:
> > Subject: [PATCH] Staging: wlan-ng: fix various whitespace and 80 char issues in hfa384x_usb.c
> > This is a patch to fix various whitespace and 80 character style issues found by checkpatch.pl tool
> > Signed-off-by: Adam Latham <adam.latham@...sontorbay.org.uk>
> 
> Hi Adam.
> 
> > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> > index 5df56f0..b7a319f 100644
> > --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> []
> > @@ -451,7 +451,7 @@ static void hfa384x_usb_defer(struct work_struct *data)
> >  	if (test_bit(WORK_RX_HALT, &hw->usb_flags)) {
> >  		int ret;
> >  
> > -		usb_kill_urb(&hw->rx_urb);	/* Cannot be holding spinlock! */
> > +		usb_kill_urb(&hw->rx_urb);	/* Cannot be holding spinlock!*/
> 
> It's most common to use a space before the trailing */

Yes, move the comment up a line to fix the "line too long" issue.

> > @@ -2619,7 +2619,7 @@ int hfa384x_drvr_start(hfa384x_t *hw)
> >  			pr_debug("First cmd_initialize() failed (result %d),\n",
> >  				 result1);
> >  			pr_debug
> > -			    ("but second attempt succeeded. All should be ok\n");
> > +			    ("but second attempt succeeded.All should be ok\n");
> 
> Removing the space after a period here is not an improvement.

Agreed, don't worry about too-long lines in print statements.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/