linux-kernel - Re: [PATCH] Disable i8042 checks on Intel Apple Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikl6J1RwgRidSMLm9Qa72PBcvXbrauzk_zUiuZ9@mail.gmail.com>
Date:	Tue, 4 May 2010 20:55:43 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Bastien Nocera <hadess@...ess.net>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH] Disable i8042 checks on Intel Apple Macs

On Tue, May 4, 2010 at 8:36 PM, Bastien Nocera <hadess@...ess.net> wrote:
> As those computers never had any i8042 controllers, and the
> current lookup code could potentially lock up/hang/wait for
> timeout for long periods of time.
>
> Fixes intermittent hangs on boot on a MacbookAir1,1

My Macbook also complains (doesn't hang though) about this:

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

> Signed-off-by: Bastien Nocera <hadess@...ess.net>
> ---
>  drivers/input/serio/i8042.c |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index d84a36e..2be7207 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -1438,12 +1438,30 @@ static struct platform_driver i8042_driver = {
>        .shutdown       = i8042_shutdown,
>  };
>
> +static struct dmi_system_id __initdata dmi_system_table[] = {
> +       {
> +               .matches = {
> +                       DMI_MATCH(DMI_BIOS_VENDOR, "Apple Computer, Inc.")
> +               },
> +       },
> +       {
> +               .matches = {
> +                       DMI_MATCH(DMI_BIOS_VENDOR, "Apple Inc.")
> +               },
> +       },
> +       {}
> +};
> +
>  static int __init i8042_init(void)
>  {
>        int err;
>
>        dbg_init();
>
> +       /* Intel Apple Macs never have an i8042 controller */
> +       if (dmi_check_system(dmi_system_table) > 0)
> +               return -ENODEV;
> +
>        err = i8042_platform_init();
>        if (err)
>                return err;
> --
> 1.6.6
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/