linux-kernel - Re: [PATCH 2/2] vgacon: use request_region(), not request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100504135155.4a4673a3@jbarnes-x201>
Date:	Tue, 4 May 2010 13:51:55 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Bjorn Helgaas <bjorn.helgaas@...com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] vgacon: use request_region(), not
 request_resource(), to set BUSY

On Tue, 04 May 2010 13:14:11 -0700
"H. Peter Anvin" <hpa@...or.com> wrote:

> On 05/04/2010 12:16 PM, Bjorn Helgaas wrote:
> > On Tuesday, May 04, 2010 01:09:46 pm Linus Torvalds wrote:
> >> On Tue, 4 May 2010, Bjorn Helgaas wrote:
> >>> Drivers normally use request_region() to mark the region busy so
> >>> it won't be used by anybody else.  Previously, we used
> >>> request_resource(), which doesn't mark the VGA regions busy.
> >>>
> >>> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>
> >>
> >> Hmm. I don't object, but unless there is some crazy regression,
> >> there's no way I will take something like this outside the merge
> >> window. Who knows what odd frame buffer driver is out there that
> >> just depended on the fact that it could also register that VGA
> >> area?
> >>
> >> Probably no such thing exists, but it's why I want these kinds of
> >> things during the merge window. And obviously preferably through
> >> something like the PCI merge tree, but that's a different issue.
> > 
> > Yep, I was intending for after .34.  I couldn't figure out where
> > to send it, but I'll be happy to send it to Jesse.
> > 
> 
> I would vote for Jesse's tree.  If Jesse doesn't want it I'll take it.

I'm happy to stuff it in my -next tree.  Bjorn can you resend?

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/